Lee-W commented on code in PR #37692:
URL: https://github.com/apache/airflow/pull/37692#discussion_r1502234461
##########
Dockerfile:
##########
@@ -494,6 +498,36 @@ function common::get_colors() {
export COLOR_YELLOW
}
+function common::get_packaging_tool() {
+ if [[ ${AIRFLOW_USE_UV} == "true" ]]; then
+ echo
+ echo "${COLOR_BLUE}Using 'uv' to install Airflow${COLOR_RESET}"
+ echo
+ export PACKAGING_TOOL="uv pip"
Review Comment:
It's more like a nitpick. But I was thinking whether we should use
`PACKAGING_TOOL="uv pip"` instead of `PACKAGING_TOOL="uv"` as `uv` is the
packaging tool which might be the reason we're not able to use something like
`${COLOR_BLUE}Using '${PACKAGING_TOOL}' to install Airflow${COLOR_RESET}"` to
reduce the duplication. Not sure whether adding env var
`PACKAGING_TOOL_INSTALL_CMD` make sense 🤔 But we might be able to reduce a few
similar lines by adding this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
