potiuk commented on code in PR #37692:
URL: https://github.com/apache/airflow/pull/37692#discussion_r1502100539


##########
scripts/docker/entrypoint_ci.sh:
##########
@@ -221,8 +221,12 @@ function check_boto_upgrade() {
     echo
     echo "${COLOR_BLUE}Upgrading boto3, botocore to latest version to run 
Amazon tests with them${COLOR_RESET}"
     echo
-    pip uninstall --root-user-action ignore aiobotocore s3fs -y || true
-    pip install --root-user-action ignore --upgrade boto3 botocore
+    # shellcheck disable=SC2086
+    ${PACKAGING_TOOL} uninstall ${EXTRA_UNINSTALL_FLAGS} aiobotocore s3fs || 
true

Review Comment:
   They are added in "EXTRA_UNINSTALL_FLAGS" for `pip`(I aded it there as full 
long option `--yes` ).  The `uv pip uninstall` does not take the `-y` or 
`--yes` flag so we cannot add it in this case (and EXTRA_UNINSTALL_FLAGS for 
`pip uv` are empty because of that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to