potiuk commented on code in PR #37789:
URL: https://github.com/apache/airflow/pull/37789#discussion_r1507985581
##########
scripts/in_container/run_generate_constraints.py:
##########
@@ -132,21 +132,21 @@ def current_constraints_file(self) -> Path:
@cached_property
def get_freeze_command(self) -> list[str]:
if self.use_uv:
- return ["uv", "pip", "freeze"]
+ return ["uv", "pip", "freeze", "--python", sys.executable]
Review Comment:
Yep. That one was a surprise. (and fixed yesterday). Yes - we could
potentially do parsing and processing them manually, but I'd still prefer to
stick to single tooling that we can switch in CI `pip <-> uv` if we can (for
now for example I am still using `pip check` for example because there is no
equivalent in uv yet). It's more for overall consistency with CI tooling - we
already do "eager upgrade", "no-provider", "pip provider" constraint check with
`uv` - so no reason to not use `pip freeze`.
But yes we can even skip it altogether and use a simple python script and
packaging to attempt the same. Maybe a next step. I am gearing up to rewrite
all the "scripts/docker" scripts to Python, so that might be a good opportunity
as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
