potiuk commented on code in PR #37789:
URL: https://github.com/apache/airflow/pull/37789#discussion_r1507993397
##########
scripts/in_container/run_generate_constraints.py:
##########
@@ -132,21 +132,21 @@ def current_constraints_file(self) -> Path:
@cached_property
def get_freeze_command(self) -> list[str]:
if self.use_uv:
- return ["uv", "pip", "freeze"]
+ return ["uv", "pip", "freeze", "--python", sys.executable]
Review Comment:
We are frozen at a specific version now - and constraints are produced daily
- long before they reach production - and that's precisely why I keep
`--use-uv/--no-use-uv` so that we can go back easily. There are days and weeks
of checking if the result of constraint generation are problematic or not and
all it needs is to switch it back by flag - and results is a text file that
can be easily generated and replaced.
I think risks there are super small.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]