Taragolis commented on code in PR #37789:
URL: https://github.com/apache/airflow/pull/37789#discussion_r1508029586
##########
scripts/in_container/run_generate_constraints.py:
##########
@@ -132,21 +132,21 @@ def current_constraints_file(self) -> Path:
@cached_property
def get_freeze_command(self) -> list[str]:
if self.use_uv:
- return ["uv", "pip", "freeze"]
+ return ["uv", "pip", "freeze", "--python", sys.executable]
Review Comment:
> It's quite incomparable to mysql
We talk about users production. Maybe it is a not a good idea to use end
users as beta testers? It is fine use it into the dev/ci for the proof of
concept, until we sure that is pretty stable. E.g. it would be nice to have the
tests which shows to us that output is compatible and until then use `pip
freeze` for constraints and pip at all for production images.
I can't see any beneficial when it comes to the frozen packages which grant
`uv pip` over the native `pip`. If compare to the fact that we could
incidentally breaks.
Use canonical name it if fine but is any reason why pip do not convert it
automatically? And maybe the reason pretty good, I just don't know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
