uranusjr commented on code in PR #38054:
URL: https://github.com/apache/airflow/pull/38054#discussion_r1521953578
##########
airflow/models/baseoperator.py:
##########
@@ -255,6 +257,7 @@ def partial(
on_retry_callback: None | TaskStateChangeCallback |
list[TaskStateChangeCallback] | ArgNotSet = NOTSET,
on_skipped_callback: None | TaskStateChangeCallback |
list[TaskStateChangeCallback] | ArgNotSet = NOTSET,
run_as_user: str | None | ArgNotSet = NOTSET,
+ executor: str | None = None,
Review Comment:
This should use `NOTSET` because we want to fallback to `default_args` when
the argument is not used by the user, instead of the default here. This is why
we have the `_PARTIAL_DEFAULTS` dict above—the fallback order is
1. User-supplied value
2. The DAG’s `default_args`
3. Value from `_PARTIAL_DEFAULTS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
