potiuk commented on code in PR #38054:
URL: https://github.com/apache/airflow/pull/38054#discussion_r1524036066
##########
airflow/models/baseoperator.py:
##########
@@ -719,6 +724,8 @@ class derived from this one results in the creation of a
task object,
"on_skipped_callback",
"do_xcom_push",
"multiple_outputs",
+ # TODO: should executor go here? I think so
+ "executor",
Review Comment:
If in doubt, mimic what you have there. _comps is used to calculate hash. if
you do not add it here, then two identical tasks with different executor might
have same hash. It's certainly wrong no matter what hash is used for. So yes it
should be added here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
