potiuk commented on code in PR #38054:
URL: https://github.com/apache/airflow/pull/38054#discussion_r1524043238


##########
airflow/models/taskinstance.py:
##########
@@ -1252,6 +1254,8 @@ class TaskInstance(Base, LoggingMixin):
     queued_dttm = Column(UtcDateTime)
     queued_by_job_id = Column(Integer)
     pid = Column(Integer)
+    # TODO: Should this be nullable?
+    executor = Column(String(1000))

Review Comment:
   Yes. Executor should ratehr be not null and historical value shoudl be set 
to default executor at migration time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to