howardyoo commented on code in PR #37948:
URL: https://github.com/apache/airflow/pull/37948#discussion_r1524176295
##########
airflow/traces/otel_tracer.py:
##########
@@ -143,25 +135,24 @@ def start_span_from_dagrun(
"""Produce a span from dag run."""
# check if dagrun has configs
conf = dagrun.conf
- trace_id = int(gen_trace_id(dag_run=dagrun), 16)
- span_id = int(gen_dag_span_id(dag_run=dagrun), 16)
+ trace_id = int(gen_trace_id(dag_run=dagrun, as_int=True))
+ span_id = int(gen_dag_span_id(dag_run=dagrun, as_int=True))
if conf is not None:
traceparent = conf.get(TRACEPARENT)
tracestate = conf.get(TRACESTATE)
- tracer = self.get_tracer_with_id(component=component, span_id=span_id,
trace_id=trace_id)
+ tracer = self.get_tracer(component=component, span_id=span_id,
trace_id=trace_id)
- kvstr = None
+ tag_string = None
# merge attributes from tags and tracestate
- if self.tags is not None:
- kvstr = self.tags
+ if self.tag_string is not None:
+ tag_string = self.tag_string
Review Comment:
OMG you're right!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
