howardyoo commented on code in PR #37948: URL: https://github.com/apache/airflow/pull/37948#discussion_r1524781847
########## airflow/traces/utils.py: ########## @@ -18,52 +18,66 @@ from __future__ import annotations import logging +from typing import TYPE_CHECKING from airflow.utils.hashlib_wrapper import md5 +if TYPE_CHECKING: + from airflow.models import DagRun, TaskInstance + from airflow.models.taskinstancekey import TaskInstanceKey + log = logging.getLogger(__name__) Review Comment: I guess by feeding the seed into the gen_id function, that could be done - we could even have `size` instead of `shorten` so I could simply feed in 16 as an input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
