ferruzzi commented on code in PR #37948: URL: https://github.com/apache/airflow/pull/37948#discussion_r1525240559
########## airflow/traces/utils.py: ########## @@ -18,52 +18,66 @@ from __future__ import annotations import logging +from typing import TYPE_CHECKING from airflow.utils.hashlib_wrapper import md5 +if TYPE_CHECKING: + from airflow.models import DagRun, TaskInstance + from airflow.models.taskinstancekey import TaskInstanceKey + log = logging.getLogger(__name__) Review Comment: Yup, I was initially thinking take an int "size" but then thought if there are only two options (16 or 32) then that sounds like a bool. Either way would work. :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
