pankajastro commented on code in PR #38247:
URL: https://github.com/apache/airflow/pull/38247#discussion_r1530855328
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -480,7 +480,8 @@ def consume_logs(*, since_time: DateTime | None = None) ->
tuple[DateTime | None
self._callbacks.progress_callback(
line=line, client=self._client,
mode=ExecutionMode.SYNC
)
- self.log.info("[%s] %s", container_name, message_to_log)
+ if message_to_log and message_to_log.strip():
+ self.log.info("[%s] %s", container_name,
message_to_log)
Review Comment:
hmm, ok so it does str strip here
https://github.com/apache/airflow/blob/d3ef6736eafa96b68032099d4158911e630e9895/airflow/providers/cncf/kubernetes/utils/pod_manager.py#L628
so strip here again is redundant and may not require.
Actually, I also find this None log a bit weird and to me it look like a bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
