pankajastro commented on PR #38247: URL: https://github.com/apache/airflow/pull/38247#issuecomment-2009006632
> Why do we need to filter empty log lines? From the reported issue, I see we have a problem with `None`, but IMHO we have to keep empty lines because the user may want to log them. WDYT? > > (requested a change to avoid merging it before discussing the solution) I'm ok to change the check to None only. 2 logs I find a bit weird 1. `INFO - [base] None` i.e logging None. coming from [pod_manager.py](https://github.com/apache/airflow/pull/38247/files#diff-6900da9281d8404b14da0815f2b37350f3148b1b63449928b952744e6711e7e7) and in this case this log is unintentional 2. `Container logs: ` i.e logging empty. coming from [pod.py](https://github.com/apache/airflow/pull/38247/files#diff-93707635f12195e7b94d14cf99675542592a28a6eb552895fb3ff37d42713740) this also look unintentional WDYT if I'll change [pod_manager.py](https://github.com/apache/airflow/pull/38247/files#diff-6900da9281d8404b14da0815f2b37350f3148b1b63449928b952744e6711e7e7) check to ```python if message_to_log is not None: ``` i.e just avoid printing None And keep [pod.py](https://github.com/apache/airflow/pull/38247/files#diff-93707635f12195e7b94d14cf99675542592a28a6eb552895fb3ff37d42713740) as it in current form? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
