hussein-awala commented on code in PR #38247:
URL: https://github.com/apache/airflow/pull/38247#discussion_r1540931015
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -781,8 +781,9 @@ def write_logs(self, pod: k8s.V1Pod):
follow=False,
)
for raw_line in logs:
- line = raw_line.decode("utf-8",
errors="backslashreplace").rstrip("\n")
- self.log.info("Container logs: %s", line)
+ line = raw_line.decode("utf-8",
errors="backslashreplace").strip()
Review Comment:
Is there any specific reason to update the strip method? If the user log
something similar to Airflow logo in our CLI, the result will be completely
different. Currently we strip new line because the logger log each message on a
new line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
