Taragolis commented on code in PR #38355:
URL: https://github.com/apache/airflow/pull/38355#discussion_r1533479362
##########
docs/apache-airflow/howto/docker-compose/docker-compose.yaml:
##########
@@ -58,6 +58,7 @@ x-airflow-common:
AIRFLOW__CELERY__RESULT_BACKEND:
db+postgresql://airflow:airflow@postgres/airflow
AIRFLOW__CELERY__BROKER_URL: redis://:@redis:6379/0
AIRFLOW__CORE__FERNET_KEY: ''
+ AIRFLOW__WEBSERVER__SECRET_KEY: 'replace_me_by_valid_key'
Review Comment:
I would also add the comment about importance of change this value. I guess
it still be a point that in production after that a lot of user would have this
as default value, the same as `airflow`:`airflow` as admin user.
I'm not sure why it is never been there, maybe some reason for that, but it
is unknown for me.
And maybe also a good idea to add a link to the configuration reference.
BTW every non empty key could be considered a valid secret key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
