Taragolis commented on code in PR #38355:
URL: https://github.com/apache/airflow/pull/38355#discussion_r1533510762


##########
docs/apache-airflow/howto/docker-compose/docker-compose.yaml:
##########
@@ -58,6 +58,7 @@ x-airflow-common:
     AIRFLOW__CELERY__RESULT_BACKEND: 
db+postgresql://airflow:airflow@postgres/airflow
     AIRFLOW__CELERY__BROKER_URL: redis://:@redis:6379/0
     AIRFLOW__CORE__FERNET_KEY: ''
+    AIRFLOW__WEBSERVER__SECRET_KEY: 'replace_me_by_valid_key'

Review Comment:
   And that is the answer why it not there 🤣 .
   
   So that mean we should add a comment in docker-compose: "Do not forget to 
add the key: <link to the doc reference>"
   
   Also might be a good idea to add info into the 
https://airflow.apache.org/docs/apache-airflow/stable/howto/docker-compose/index.html,
 like add `AIRFLOW__WEBSERVER__SECRET_KEY` with a "strong" value which you 
could generate for example by run (source: 
https://unix.stackexchange.com/a/230676)
   
   ```console
   tr -dc 'A-Za-z0-9!"#$%&'\''()*+,-./:;<=>?@[\]^_`{|}~' </dev/urandom | head 
-c 63; echo
   ```
   
   The same maybe valid for Fernet key I do not know how many users of this 
docker-compose run with an empty Fernet key



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to