potiuk commented on code in PR #38355:
URL: https://github.com/apache/airflow/pull/38355#discussion_r1533489210
##########
docs/apache-airflow/howto/docker-compose/docker-compose.yaml:
##########
@@ -58,6 +58,7 @@ x-airflow-common:
AIRFLOW__CELERY__RESULT_BACKEND:
db+postgresql://airflow:airflow@postgres/airflow
AIRFLOW__CELERY__BROKER_URL: redis://:@redis:6379/0
AIRFLOW__CORE__FERNET_KEY: ''
+ AIRFLOW__WEBSERVER__SECRET_KEY: 'replace_me_by_valid_key'
Review Comment:
Yes. We cannot add it this way. We used to have similar key in Airflow
config by default and it has been reported and fixed as security vulnerability
(and fixed by removing the key) - precisely because people did not change it in
production when they used our default settings. They might usethe docker
compose as starting point . I think we should instead update instructions in
https://airflow.apache.org/docs/apache-airflow/stable/howto/docker-compose/index.html
on how to generate random key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
