maresb opened a new pull request, #38387:
URL: https://github.com/apache/airflow/pull/38387
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Respect the `DOCKER_HOST` environment variable with the DockerOperator.
<!-- Please keep an empty line above the dashes. -->
---
I was really surprised that the `DOCKER_HOST` environment variable is
ignored. I was also surprised that I didn't find any proposal to add it, so
apologies in case I missed a previous discussion. Might this be an acceptable
change?
Of course this will break in situations where `DOCKER_HOST` is set, but the
user is relying on the default value of `docker_url` to override this setting.
Having such a setup is really begging for trouble, so I wouldn't feel so guilty
about breaking those cases.
TODO if I get :+1: to proceed:
- [ ] Add tests (any suggestions?)
- [ ] In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
- [ ] Anything else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
