maresb commented on PR #38387:
URL: https://github.com/apache/airflow/pull/38387#issuecomment-2014667366

   Thanks so much @Taragolis for the advice! I will look into it.
   
   > Is it backward incompatible change?
   
   It depends on your definition of "backward incompatible". The only breakage 
I can imagine is quite contrived:
   
   * The user is running two Docker hosts, one on the default 
`unix://var/run/docker.sock` and the other on `tcp://docker-proxy:2375`. The 
user intends to use `unix://var/run/docker.sock` with Airflow and 
`tcp://docker-proxy:2375` with everything else, so they set 
`DOCKER_HOST=tcp://docker-proxy:2375` and rely otherwise on the default value 
of `docker_url` for Airflow.
   * The fix in this case is that, after this PR has been merged, the user must 
explicitly set `docker_url="unix://var/run/docker.sock"` in order to override 
the value in `DOCKER_HOST`.
   
   Do you think this warrants a newsfragment?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to