Taragolis commented on code in PR #38387:
URL: https://github.com/apache/airflow/pull/38387#discussion_r1535491409
##########
airflow/decorators/__init__.pyi:
##########
@@ -327,7 +328,7 @@ class TaskDecoratorCollection:
api_version: str | None = None,
container_name: str | None = None,
cpus: float = 1.0,
- docker_url: str = "unix://var/run/docker.sock",
+ docker_url: str = environ.get("DOCKER_HOST") or
"unix://var/run/docker.sock",
Review Comment:
I don't think we should add expressions into the stub file. It is not
evaluated in runtime.
##########
airflow/providers/docker/operators/docker.py:
##########
@@ -26,6 +26,7 @@
from collections.abc import Container
from functools import cached_property
from io import BytesIO, StringIO
+from os import environ
Review Comment:
Small nit
Just import `os` an use as `os.environ` as more convenient way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
