potiuk commented on PR #38489:
URL: https://github.com/apache/airflow/pull/38489#issuecomment-2020937536
BTW. If we want to be **REALLY** correct here - every time we send a
ValueError (i.e. user provided a value that is wrong), we should do:
```
get_console().print("[error]The value xxxx you provided is wrong, correct
value is .....")
sys.exit(1)
```
Generally speaking raising exception when user input and user console tools
is involved, is quite wrong.. So if we want to correct it, then I'd rather say:
* RuntimeError, whenever it is an irrecoverable error that user has no
influence on
* sys.exit(1) with `[error]` message and advice to the user in all other
cases. will make some suggestions.
*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
