potiuk commented on code in PR #38489:
URL: https://github.com/apache/airflow/pull/38489#discussion_r1539701523
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -1066,7 +1066,7 @@ def _get_all_providers_in_dist(
for file in DIST_DIR.glob(f"{filename_prefix}*.tar.gz"):
matched = filename_pattern.match(file.name)
if not matched:
- raise Exception(f"Cannot parse provider package name from
{file.name}")
+ raise ValueError(f"Cannot parse provider package name from
{file.name}")
Review Comment:
sys.exit() here.
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -1091,7 +1091,7 @@ def get_all_providers_in_dist(package_format: str,
install_selected_providers: s
)
)
else:
- raise Exception(f"Unknown package format {package_format}")
+ raise ValueError(f"Unknown package format {package_format}")
Review Comment:
sys.exit() here.
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -1091,7 +1091,7 @@ def get_all_providers_in_dist(package_format: str,
install_selected_providers: s
)
)
else:
- raise Exception(f"Unknown package format {package_format}")
+ raise ValueError(f"Unknown package format {package_format}")
Review Comment:
sys.exit() here.
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -1066,7 +1066,7 @@ def _get_all_providers_in_dist(
for file in DIST_DIR.glob(f"{filename_prefix}*.tar.gz"):
matched = filename_pattern.match(file.name)
if not matched:
- raise Exception(f"Cannot parse provider package name from
{file.name}")
+ raise ValueError(f"Cannot parse provider package name from
{file.name}")
Review Comment:
sys.exit() here.
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -1066,7 +1066,7 @@ def _get_all_providers_in_dist(
for file in DIST_DIR.glob(f"{filename_prefix}*.tar.gz"):
matched = filename_pattern.match(file.name)
if not matched:
- raise Exception(f"Cannot parse provider package name from
{file.name}")
+ raise ValueError(f"Cannot parse provider package name from
{file.name}")
Review Comment:
sys.exit() here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
