potiuk commented on code in PR #38489:
URL: https://github.com/apache/airflow/pull/38489#discussion_r1539704361
##########
dev/breeze/src/airflow_breeze/utils/docs_publisher.py:
##########
@@ -58,15 +58,15 @@ def _build_dir(self) -> str:
@property
def _current_version(self):
if not self.is_versioned:
- raise Exception("This documentation package is not versioned")
+ raise ValueError("This documentation package is not versioned")
if self.package_name == "apache-airflow":
return get_airflow_version()
if self.package_name.startswith("apache-airflow-providers-"):
provider =
get_provider_packages_metadata().get(get_short_package_name(self.package_name))
return provider["versions"][0]
if self.package_name == "helm-chart":
return chart_version()
- return Exception(f"Unsupported package: {self.package_name}")
+ return ValueError(f"Unsupported package: {self.package_name}")
Review Comment:
sys.exit here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
