pankajkoti commented on code in PR #38601:
URL: https://github.com/apache/airflow/pull/38601#discussion_r1545631644
##########
.github/workflows/push-image-cache.yml:
##########
@@ -20,10 +20,9 @@ name: Push image cache
on: # yamllint disable-line rule:truthy
workflow_call:
inputs:
- runs-on:
- description: "The array of labels (in json form) determining type of
the runner to use for the build."
- required: false
- default: "[\"ubuntu-22.04\"]"
+ runs-on-as-string:
Review Comment:
Based on the previous
[comment](https://github.com/apache/airflow/pull/38601#discussion_r1545612621)
if we decide to accept the previous comment.
##########
.github/workflows/push-image-cache.yml:
##########
@@ -76,7 +75,7 @@ on: # yamllint disable-line rule:truthy
jobs:
push-ci-image-cache:
name: "Push CI ${{ inputs.cache-type }}:${{ matrix.python }} image cache "
- runs-on: ${{ fromJSON(inputs.runs-on) }}
+ runs-on: ${{ fromJSON(inputs.runs-on-as-string) }}
Review Comment:
```suggestion
runs-on: ${{ fromJSON(inputs.public-runs-on-as-string) }}
```
Based on the previous
[comment](https://github.com/apache/airflow/pull/38601#discussion_r1545612621)
if we decide to accept the previous comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
