potiuk commented on PR #38601:
URL: https://github.com/apache/airflow/pull/38601#issuecomment-2028721875
@hussein-awala :
> I don't think the as-string suffix makes it clearer here, personally, I
prefer to keep the name pattern <type>-runs-on or <type>-runs-on-as-json as we
can use the string without any issue in most of the cases, but here we want to
load an array from the string.
Yep. good point. I also reverted the sequenece and we have now:
```
runs-on-as-json-default: ${{
steps.selective-checks.outputs.runs-on-as-json-default }}
runs-on-as-json-self-hosted: ${{
steps.selective-checks.outputs.runs-on-as-json-self-hosted }}
runs-on-as-json-public: ${{
steps.selective-checks.outputs.runs-on-as-json-public }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
