potiuk commented on code in PR #38601:
URL: https://github.com/apache/airflow/pull/38601#discussion_r1545656973
##########
.github/workflows/additional-ci-image-checks.yml:
##########
@@ -93,7 +96,7 @@ jobs:
packages: write
secrets: inherit
with:
- # Runs on Public runners
+ runs-on-as-string: ${{ inputs.public-runs-on-as-string }}
Review Comment:
yeah. It was another (a bit) of inconsistency. I just thought that in case
of those two workflows (pushing cache and building images) we always know which
runner we want to use, and I wanted to pass the right one). Those workflows
could be executed with `public` or `self-hosted` depending on the platform
(AMD/ ARM). I just wanted to avoid pushing both as parameters and making the
choice in the final workflow, but I think yeah, this is the right approach - so
I pushed a change with this ternary down to the "leaf" workflows - as this will
make run-as parameters even more explicit and consistent.
```
${{ inputs.platform == 'linux/amd' &&
fromJSON(inputs.runs-on-as-json-public) ||
fromJSON(inputs.runs-on-as-json-self-hosted) }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
