o-nikolas commented on code in PR #38514:
URL: https://github.com/apache/airflow/pull/38514#discussion_r1548693252
##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -270,8 +270,10 @@ def _debug_dump(self, signum: int, frame: FrameType |
None) -> None:
self.log.info("%s\n%s received, printing debug\n%s", "-" * 80,
sig_name, "-" * 80)
- self.job.executor.debug_dump()
- self.log.info("-" * 80)
+ for executor in self.job.executors:
+ self.log.info("Debug dump for the executor %s", executor)
+ executor.debug_dump()
+ self.log.info("-" * 80)
Review Comment:
I don't necessarily disagree with you, but this was what was done
previously. I try with these changes not to snowball the intent of the PR.
Today people know to expect that `---...`header when they're looking through
the logs for the executor debug dump. I don't think this PR should be
opinionated about that and change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
