dstandish commented on code in PR #38514:
URL: https://github.com/apache/airflow/pull/38514#discussion_r1549952673
##########
airflow/jobs/job.py:
##########
@@ -104,12 +105,13 @@ class Job(Base, LoggingMixin):
Only makes sense for SchedulerJob and BackfillJob instances.
"""
- def __init__(self, executor=None, heartrate=None, **kwargs):
+ def __init__(self, executor: BaseExecutor | None = None, heartrate=None,
**kwargs):
# Save init parameters as DB fields
self.heartbeat_failed = False
self.hostname = get_hostname()
if executor:
self.executor = executor
+ self.executors = [executor]
Review Comment:
Yeah I don't think Job should be public, whether it is or not. So updating
it, and not having sorta duplicate attrs, feels like the right move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
