howardyoo commented on PR #37948: URL: https://github.com/apache/airflow/pull/37948#issuecomment-2046324781
> I tried to look at this PR finally and it is huge to review. I have a proposal though @howardyoo : Can you attempt to split split out adding traces separately for smaller subset a) add general functionality of enabling OTEL first, and then add "piece by piece" adding spans in different parts of Airflow that are focusing on one part of the code/functionality only? > > I think this will be far easier to review and we could pull in other people who would be more familiar with different parts of the code. The way I did it in the past - I kept my original PR as a DRAFT and then extracted part of it which could be separated out as standalone - much smaller and much more focused. Then After merging each small PR, I'd rebase the "complete" one and get it smaller and smaller once individual parts of it are merged. Hi Jarek, I think that's possible, as when I was doing the major rebase, I pretty much know which part the OTEL trace enablement is, vs. which part is the instrumentations themselves. Let me see what I can do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
