howardyoo commented on PR #37948: URL: https://github.com/apache/airflow/pull/37948#issuecomment-2046329683
> Also - purely practically - I think this change has a high-cherry-pick-breaking potential. We should deliberately start merging it from the changes that have the least potential conflict generation potential (where we break indents and merge the more conflict-inducing chnages later on as we get a bit closer to 2.10.0, otherwise it will be difficult to cherry-pick changes after those merges. Sure, that would be the part where OTEL tracing part is implemented. Without any actual instrumentations, those will introduce the least conflicts / impact. The first part should be: =================== airflow/config_templates/config.yml airflow/www/views.py airflow/www/templates/airflow/dags.html docs/apache-airflow/administration-and-deployment/logging-monitoring/metrics.rst scripts/ci/docker-compose/integration-otel.yml scripts/ci/docker-compose/otel-collector-config.yml airflow/traces/ - __init__.py - otel_tracer.py - tracer.py - utils.py - airflow/utils/dates.py tests/core/test_otel_tracer.py And the second part should be: ======================== airflow/dag_processing/manager.py airflow/executors/base_executor.py airflow/executors/local_executor.py airflow/executors/sequential_executor.py airflow/jobs/job.py airflow/jobs/local_task_job_runner.py airflow/jobs/scheduler_job_runner.py airflow/jobs/trigger_job_runner.py airflow/models/dagrun.py airflow/models/taskinstance.py I think this second part could also be further separated per modules: 1. dag_processing 2. executors 3. jobs 4. models What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
