uranusjr commented on code in PR #37948:
URL: https://github.com/apache/airflow/pull/37948#discussion_r1560428293
##########
airflow/dag_processing/manager.py:
##########
@@ -1029,6 +1051,25 @@ def _collect_results_from_processor(self, processor) ->
None:
)
self._file_stats[processor.file_path] = stat
file_name = Path(processor.file_path).stem
+
+ """crude exposure of instrumentation code which may need to be
furnished"""
+ span = Trace.get_tracer("DagFileProcessorManager").start_span(
+ "dag_processing", start_time=datetime_to_nano(processor.start_time)
Review Comment:
Is it possible for tracers to just accept datetime objects instead? From
past experience with StatsD, using a raw number as value is prone to user
errors, especially since Airflow does not otherwise use nanoseconds, but either
milliseconds or seconds instead. Having two time units is already one too many,
adding a third one isn’t a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
