o-nikolas commented on code in PR #38524:
URL: https://github.com/apache/airflow/pull/38524#discussion_r1567800322
##########
chart/values.schema.json:
##########
@@ -521,7 +521,8 @@
"LocalKubernetesExecutor",
"CeleryExecutor",
"KubernetesExecutor",
- "CeleryKubernetesExecutor"
+ "CeleryKubernetesExecutor",
+
"airflow.providers.amazon.aws.executors.ecs.ecs_executor.AwsEcsExecutor"
Review Comment:
Somehow I missed the first time I was tagged in this thread.
> @o-nikolas, is there a plan to eventually have a short alias for
AwsEcsExecutor vs requiring the full path?
A while ago I had suggested a way to "register" custom executors with the
same sort of alias namespace that the Airflow core executors use. But it didn't
get much traction.
We could probably do some python trickery to make the aws executors
importable from something like `airflow.providers.amazon.aws.executors` using
`__init__` or another module in that dir that we import all the available
executors into? Or maybe one module per executor?
> So probably we should accept this PR and open a followup issue cc
@o-nikolas
I'm not so sure of this. Can someone clarify if the 50 char limit is a
blocker for this PR? I see that the value is getting truncated which I think
would completely break the import path, right? So as is, this PR is not
mergeable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
