o-nikolas commented on code in PR #38524:
URL: https://github.com/apache/airflow/pull/38524#discussion_r1569312762
##########
chart/templates/scheduler/scheduler-deployment.yaml:
##########
@@ -53,7 +53,7 @@ metadata:
release: {{ .Release.Name }}
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
heritage: {{ .Release.Service }}
- executor: {{ .Values.executor }}
+ executor: {{ trunc -63 .Values.executor }} # AWS ECS Executor name is too
long.
Review Comment:
I would drop this. Truncating an executor import path will cause the
executor to fail to load, but that failure will happen much later. So this kind
of hides that. I think it's good for helm/k8s to catch the label being too long
and then fixing that earlier.
##########
chart/values.schema.json:
##########
@@ -521,7 +521,9 @@
"LocalKubernetesExecutor",
"CeleryExecutor",
"KubernetesExecutor",
- "CeleryKubernetesExecutor"
+ "CeleryKubernetesExecutor",
+
"airflow.providers.amazon.aws.executors.batch.AwsBatchExecutor",
+ "airflow.providers.amazon.aws.executors.ecs.AwsEcsExecutor"
Review Comment:
@jedcunningham @LipuFei
I don't know enough about Helm: will this import these modules from local
sources (a repo checked out or something equivalent). Or does it depend on the
changes from #39093 being published in the next provider release wave?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
