o-nikolas commented on code in PR #38524:
URL: https://github.com/apache/airflow/pull/38524#discussion_r1568030436
##########
chart/templates/scheduler/scheduler-deployment.yaml:
##########
@@ -53,7 +53,7 @@ metadata:
release: {{ .Release.Name }}
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
heritage: {{ .Release.Service }}
- executor: {{ .Values.executor }}
+ executor: {{ trunc -50 .Values.executor }} # AWS ECS Executor name is too
long.
Review Comment:
I was looking into the kubernetes docs and I'm reading that the limit is 63
characters, is there any reason we're limiting to 50 here?
source:
https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
