o-nikolas commented on code in PR #38524:
URL: https://github.com/apache/airflow/pull/38524#discussion_r1569360274
##########
chart/templates/scheduler/scheduler-deployment.yaml:
##########
@@ -53,7 +53,7 @@ metadata:
release: {{ .Release.Name }}
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
heritage: {{ .Release.Service }}
- executor: {{ .Values.executor }}
+ executor: {{ trunc -63 .Values.executor }} # AWS ECS Executor name is too
long.
Review Comment:
Okay, cool, that was the question I had here:
> Can someone clarify if the 50 char limit is a blocker for this PR? I see
that the value is getting truncated which I think would completely break the
import path, right? So as is, this PR is not mergeable?
So if the label thing means nothing (functionally), then we should keep the
truncation on this line and also use the current/long module paths, since the
newer short ones wont be available in the current images until a future release.
I'd still like to merge the short names for future use, since I like that
they're shorter and tidier.
Does that sound good @jedcunningham @LipuFei ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
