LipuFei commented on code in PR #38524:
URL: https://github.com/apache/airflow/pull/38524#discussion_r1570216999
##########
chart/templates/scheduler/scheduler-deployment.yaml:
##########
@@ -53,7 +53,7 @@ metadata:
release: {{ .Release.Name }}
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
heritage: {{ .Release.Service }}
- executor: {{ .Values.executor }}
+ executor: {{ trunc -63 .Values.executor }} # AWS ECS Executor name is too
long.
Review Comment:
I'm getting a little lost in the discussions... I'll try to summarize and
see if you agree:
1. We will keep `trunc 63` because it's just an informational label on the
Deployment.
2. We will add the long paths for the executors into the allowed values list
to avoid the dependency on #39093
Do you agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
