Taragolis commented on code in PR #39408:
URL: https://github.com/apache/airflow/pull/39408#discussion_r1590071500
##########
airflow/providers/oracle/hooks/oracle.py:
##########
@@ -251,8 +251,7 @@ def insert_rows(
table: str,
rows: list[tuple],
target_fields=None,
- commit_every: int = 1000,
- replace: bool | None = False,
+ commit_every: int = 1000
Review Comment:
You can't remove `replace` argument, because it is comes from the
`DbApiHook. insert_rows`
https://github.com/apache/airflow/blob/08f4b923ab6fe63aad72e3a9da9507ed5b9c6932/airflow/providers/common/sql/hooks/sql.py#L555-L565
If you would like to inform user that it doesn't take any affect for
OracleHook you could inform by:
- Mentioned it into the docstring
- Warn users by appropriate warning message: `warning.warn("Foo bar do not
use that", category=UserWarning, stacklevel=2)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
