syedahsn commented on code in PR #39408:
URL: https://github.com/apache/airflow/pull/39408#discussion_r1591510504
##########
airflow/providers/oracle/hooks/oracle.py:
##########
@@ -272,8 +272,14 @@ def insert_rows(
:param commit_every: the maximum number of rows to insert in one
transaction
Default 1000, Set greater than 0.
Set 1 to insert each row in each single transaction
- :param replace: Whether to replace instead of insert
+ :param replace: Does not do anything.
Review Comment:
I would leave the initial intended use-case of the parameter, and just
mention that it is not currently implemented, like how you've done with the
warning. Leaving it as `Does not do anything` will be confusing for anyone who
sees it later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
