RichieSK commented on code in PR #39408:
URL: https://github.com/apache/airflow/pull/39408#discussion_r1590080737
##########
airflow/providers/oracle/hooks/oracle.py:
##########
@@ -251,8 +251,7 @@ def insert_rows(
table: str,
rows: list[tuple],
target_fields=None,
- commit_every: int = 1000,
- replace: bool | None = False,
+ commit_every: int = 1000
Review Comment:
I've reintroduced the replace parameter and implemented both suggestions to
inform the user. Is the current version fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
