uranusjr commented on code in PR #40377:
URL: https://github.com/apache/airflow/pull/40377#discussion_r1650347100
##########
airflow/providers/ssh/hooks/ssh.py:
##########
@@ -283,6 +283,7 @@ def host_proxy(self) -> paramiko.ProxyCommand | None:
cmd = self.host_proxy_cmd
return paramiko.ProxyCommand(cmd) if cmd else None
+ @cached_property
Review Comment:
I don’t think you can use `cached_property` here since it turns this from a
function to a property. `methodtools.lru_cache` would be more appropriate.
(Search the code base for some examples.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
