uranusjr commented on code in PR #40447:
URL: https://github.com/apache/airflow/pull/40447#discussion_r1675119678
##########
airflow/utils/log/log_reader.py:
##########
@@ -40,7 +40,7 @@ class TaskLogReader:
"""Time to sleep between loops while waiting for more logs"""
def read_log_chunks(
- self, ti: TaskInstance, try_number: int | None, metadata
+ self, ti: TaskInstance, try_number: int | None, metadata, page_number:
int | None = None
Review Comment:
I was thinking that in general we should use the offset/limit approach
rather than maintaining a page number. We can (should?) still show the page
number in the web UI, but those should always be converted in the frontend to
an offset to talk to the log server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
