andyjianzhou commented on code in PR #40447:
URL: https://github.com/apache/airflow/pull/40447#discussion_r1675625768
##########
airflow/utils/log/log_reader.py:
##########
@@ -40,7 +40,7 @@ class TaskLogReader:
"""Time to sleep between loops while waiting for more logs"""
def read_log_chunks(
- self, ti: TaskInstance, try_number: int | None, metadata
+ self, ti: TaskInstance, try_number: int | None, metadata, page_number:
int | None = None
Review Comment:
So I have a question, you brought up the usage of using offset/limit
approach, however wouldn't it be a lot more simpler and intuitive if we used
`log_pos`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
