jedcunningham commented on code in PR #40441:
URL: https://github.com/apache/airflow/pull/40441#discussion_r1675380889
##########
airflow/models/taskinstancehistory.py:
##########
@@ -45,8 +47,50 @@ class TaskInstanceHistory(Base):
run_id = Column(StringID(), nullable=False)
map_index = Column(Integer, nullable=False, server_default=text("-1"))
try_number = Column(Integer, nullable=False)
+ # TODO: duplicate TI table in TIhistory and use pre-commit hook to keep
both in sync.
+ trigger_id = Column(Integer)
# The rest of the columns are kept in sync with TaskInstance, added at the
bottom of this file
+ dag_run = relationship(
Review Comment:
Having to keep these relationships in sync feels a little messy. I wonder if
instead we should have a different response schema that cuts out all this extra
stuff, and just returns the TI specific stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
