ephraimbuddy commented on code in PR #40441:
URL: https://github.com/apache/airflow/pull/40441#discussion_r1675444096


##########
airflow/models/taskinstancehistory.py:
##########
@@ -45,8 +47,50 @@ class TaskInstanceHistory(Base):
     run_id = Column(StringID(), nullable=False)
     map_index = Column(Integer, nullable=False, server_default=text("-1"))
     try_number = Column(Integer, nullable=False)
+    # TODO: duplicate TI table in TIhistory and use pre-commit hook to keep 
both in sync.
+    trigger_id = Column(Integer)
     # The rest of the columns are kept in sync with TaskInstance, added at the 
bottom of this file
 
+    dag_run = relationship(

Review Comment:
   I think it’s ok since the relationships are just view only. A bit messy but 
we might need more queries if we have a separate schema? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to