Lee-W commented on code in PR #40441:
URL: https://github.com/apache/airflow/pull/40441#discussion_r1686161168


##########
airflow/api_connexion/schemas/task_instance_schema.py:
##########
@@ -86,6 +87,38 @@ def get_attribute(self, obj, attr, default):
         return get_value(obj[0], attr, default)
 
 
+class TaskInstanceHistorySchema(SQLAlchemySchema):
+    """Task instance schema."""
+
+    class Meta:
+        """Meta."""
+
+        model = TaskInstanceHistory
+
+    task_id = auto_field()
+    dag_id = auto_field()
+    run_id = auto_field(data_key="dag_run_id")

Review Comment:
   I'm ok with `run_id` but just want to confirm whether we need/want to change 
`dag_run_id` to `run_id`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to