ephraimbuddy commented on code in PR #40867:
URL: https://github.com/apache/airflow/pull/40867#discussion_r1684755334
##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -1066,6 +1068,14 @@ def _run_scheduler_loop(self) -> None:
num_finished_events += self._process_executor_events(
executor=executor, session=session
)
+
+ for executor in self.job.executors:
+ try:
+ with create_session() as session:
+
self._process_task_event_logs(executor._task_event_logs, session)
Review Comment:
What do you think about moving it into the _process_executor_events method
of the scheduler. I think with that, we might not have to iterate over the
executors twice(see line 1068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
