vincbeck commented on code in PR #40867:
URL: https://github.com/apache/airflow/pull/40867#discussion_r1684839047
##########
airflow/executors/base_executor.py:
##########
@@ -139,6 +148,10 @@ def __repr__(self):
def start(self): # pragma: no cover
"""Executors may need to get things started."""
+ def log_task_event(self, *, event: str, extra: str, ti_key:
TaskInstanceKey):
Review Comment:
Oh I see! Good catch! And thanks for the explanations. Anyway I feel like it
is easier for users to use this method using this signature than having to
create a `Log` object
##########
airflow/executors/base_executor.py:
##########
@@ -139,6 +148,10 @@ def __repr__(self):
def start(self): # pragma: no cover
"""Executors may need to get things started."""
+ def log_task_event(self, *, event: str, extra: str, ti_key:
TaskInstanceKey):
Review Comment:
So double win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
