dstandish commented on code in PR #40867:
URL: https://github.com/apache/airflow/pull/40867#discussion_r1684882967
##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -1066,6 +1068,14 @@ def _run_scheduler_loop(self) -> None:
num_finished_events += self._process_executor_events(
executor=executor, session=session
)
+
+ for executor in self.job.executors:
+ try:
+ with create_session() as session:
+
self._process_task_event_logs(executor._task_event_logs, session)
Review Comment:
i thought it better to do in separate transactions. one matters for task
execution and scheduler behavior. one is just logging events. maybe i'm am
being overly cautious but i was thinking to defend against bad behavior in
executor event logging. i don't have a strong feeling about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
