Lee-W commented on code in PR #40868:
URL: https://github.com/apache/airflow/pull/40868#discussion_r1687497644
##########
airflow/datasets/__init__.py:
##########
@@ -271,6 +306,20 @@ def iter_datasets(self) -> Iterator[tuple[str, Dataset]]:
yield k, v
seen.add(k)
+ def iter_dag_deps(self, *, source: str, target: str) ->
Iterator[DagDependency]:
+ """
+ Iterate dataset, dataset aliases and their resolved datasets as dag
dependency.
+
+ :meta private:
+ """
+ dag_deps: set[DagDependency] = set()
Review Comment:
Sure.
currently, a DAG with `schedule=[Dataset("1"), Dataset("1")]` will generate
the following graph.
```mermaid
flowchart LR
dataset1 --> DAG1
```
By not deduplicate, my understanding is we want to have something like this.
Then we'll have to mark that the frist `Dataset("1")` and the second
`Dataset("1")` are different. It's not undoable. Just not sure whether it makes
sense.
```mermaid
flowchart LR
dataset1 --> DAG1
dataset1 --> DAG1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
