Lee-W commented on code in PR #40868:
URL: https://github.com/apache/airflow/pull/40868#discussion_r1687578288
##########
airflow/datasets/__init__.py:
##########
@@ -271,6 +306,20 @@ def iter_datasets(self) -> Iterator[tuple[str, Dataset]]:
yield k, v
seen.add(k)
+ def iter_dag_deps(self, *, source: str, target: str) ->
Iterator[DagDependency]:
+ """
+ Iterate dataset, dataset aliases and their resolved datasets as dag
dependency.
+
+ :meta private:
+ """
+ dag_deps: set[DagDependency] = set()
Review Comment:
> say ("a" | "b") & ("a" | "c"). This cannot be simplified, but we only want
one line to a instead of two.
I guess I'm a bit confused. What do you expect the UI to look like in this
situation? It would look something like the following now.
```mermaid
flowchart LR
a --> DAG
b --> DAG
c --> DAG
```
If we don't duplicate (for cases that can't actually be dedup), I would
probably want something like this.
```mermaid
flowchart LR
a --> Or1
b --> Or1
a --> Or2
c --> Or2
Or1 --> And
Or2 --> And
And --> DAG
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
